Use new Lock & make internal + private classes sealed to avoid virtual dispatch - #998
Merged
Merged
Conversation
KevinJump
added a commit
that referenced
this pull request
Aug 5, 2026
* Avoid some unneeded dictionary operations (#997) (cherry picked from commit 1d06d7c) * Use new Lock & make internal + private classes sealed to avoid virtual dispatch (#998) (cherry picked from commit 3109ab6) * Changelog for the v17 perf ports (#997, #998) Records the SyncChangeInfo sealing, which is a (minor) extender API change: it stays protected so handlers can still construct one from an IsItemCurrentAsync override, but can no longer be derived from. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Henrik <hg@impact.dk> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
KevinJump
added a commit
that referenced
this pull request
Aug 5, 2026
…1020) ClaimItemForExport locked on notification.State - Umbraco's dictionary, not ours. Anything else holding a reference to it could contend with us on an object neither side knows the other is using. Replaced with a private static Lock, following the pattern from #998. Statics on a generic type are per closed type, so documents and elements get a lock each. That suits us: they never share a notification state, so they have nothing to contend over. Added a test that races the claim across threads. Verified it fails without the lock - concurrent HashSet.Add corrupts the set and throws IndexOutOfRangeException - so it actually proves the guard is doing something. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.