Fix GitVersion branch regex to match v17/main - #1058
Merged
Conversation
The main-branch regex was still pinned to v15/main, so GitVersion couldn't match v17/main, found no fallback branch config, and threw (surfacing as "GitVersion output is not valid JSON" in the Build and Package workflow). Generalize the regex to match any vNN/main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v17/mainsince it was enabled there (Run PR build/test and package workflows on v17/main #1056) withGitVersion output is not valid JSON.GitVersion.yml'smainbranch config regex was still^v15\/main$, so GitVersion couldn't matchv17/main, found no branch to inherit config from, and threwInvalidOperationException.^v\d+\/main$so it matches the current LTS branch and future ones without needing edits per version bump.Test plan
dotnet-gitversionlocally against this repo/config before the fix — reproduced the crash (Gitversion could not determine which branch to treat as the development branch...).17.3.9-ci.4).