Skip to content

Fix silently discarded save failures in Language/DictionaryItem/Webhook serializers (v18 port) #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinJump merged 1 commit into from
Aug 16, 2026
Merged

Fix silently discarded save failures in Language/DictionaryItem/Webhook serializers (v18 port) #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion uSync.Core/Serialization/Serializers/DictionaryItemSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,18 @@ private async Task<int> GetLevelAsync(IDictionaryItem item, int level = 0)
}

public override async Task SaveItemAsync(IDictionaryItem item)
=> _ = item.HasIdentity
{
var attempt = item.HasIdentity
? await _dictionaryItemService.UpdateAsync(item, Constants.Security.SuperUserKey)
: await _dictionaryItemService.CreateAsync(item, Constants.Security.SuperUserKey);

if (attempt.Success is false)
{
throw new InvalidOperationException(
$"Could not save dictionary item {item.ItemKey}: {attempt.Status}");
}
}

public override Task DeleteItemAsync(IDictionaryItem item)
=> _dictionaryItemService.DeleteAsync(item.Key, Constants.Security.SuperUserKey);

Expand Down
10 changes: 9 additions & 1 deletion uSync.Core/Serialization/Serializers/LanguageSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,18 @@ public override bool IsValid(XElement node)
=> Task.FromResult(default(ILanguage));

public override async Task SaveItemAsync(ILanguage item)
=> _ = item.HasIdentity
{
var attempt = item.HasIdentity
? await _languageService.UpdateAsync(item, Constants.Security.SuperUserKey)
: await _languageService.CreateAsync(item, Constants.Security.SuperUserKey);

if (attempt.Success is false)
{
throw new InvalidOperationException(
$"Could not save language {item.IsoCode}: {attempt.Status}");
}
}

public override Task DeleteItemAsync(ILanguage item)
=> _languageService.DeleteAsync(item.IsoCode, Constants.Security.SuperUserKey);

Expand Down
12 changes: 11 additions & 1 deletion uSync.Core/Serialization/Serializers/WebhookSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,17 @@ public override string ItemAlias(IWebhook item)
/// <inheritdoc/>
///
public override async Task SaveItemAsync(IWebhook item)
=> _ = item.HasIdentity ? await _webhookService.UpdateAsync(item) : await _webhookService.CreateAsync(item);
{
var attempt = item.HasIdentity
? await _webhookService.UpdateAsync(item)
: await _webhookService.CreateAsync(item);

if (attempt.Success is false)
{
throw new InvalidOperationException(
$"Could not save webhook {item.Key}: {attempt.Status}");
}
}

/// <inheritdoc/>
protected override async Task<SyncAttempt<IWebhook>> DeserializeCoreAsync(XElement node, SyncSerializerOptions options)
Expand Down
Loading