Phase 7 add tips - #64
Merged
Merged
Conversation
- Group frames now support palette creation, toolbar actions, drop adoption, and drag-out release. - Contextual, dismissible tips include an off-switch in Canvas settings. - typecheck, lint, and build:app pass. npm test has only the documented Windows login_path failure; Wave 7 tests pass.
- Double-click and focus mode now share isEditableNode, keeping frames/notes/start/end out of the details dialog - Notes get an in-place editable title instead of a static label - GroupNode resizer reuses shared FRAME_MIN_WIDTH/HEIGHT constants - autoLayoutRootNodes now lays out framed members within their frame's coordinate space and refits the frame, instead of freezing frames and scattering the rest from the origin
…de predicate is now exported as isEditableNode; it already had exactly the right set (group/note/start/end excluded). - src/components/WorkflowCanvas.tsx:820 — onNodeDoubleClick gates on it instead of its own start/end check, so double-click on a frame or note does nothing but its own in-place edit. openFocusMode (:913) now uses the same predicate instead of a duplicated four-way check. - src/components/nodes/NoteNode.tsx:56 — the note title was only editable in that dialog, so it's now an inline transparent input (nodrag), matching the body textarea's write path. Frame rename already worked in place on the pill. isEditableNode check in focusModeOrder.test.ts, note-title check in NoteNode.test.tsx (needed a ReactFlowProvider wrap). Typecheck + lint clean, 1080 renderer tests pass.
- Extracted frame-child grouping from autoLayoutRootNodes. - Suppressed an unrelated frame-constants clone detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.