Skip to content

fix(onboarding): use storageServiceProvider instead of raw StorageService - #23

Merged
KashifKhn merged 2 commits into
mainfrom
fix/onboarding-storage-provider
Aug 11, 2026
Merged

fix(onboarding): use storageServiceProvider instead of raw StorageService#23
KashifKhn merged 2 commits into
mainfrom
fix/onboarding-storage-provider

Conversation

@KashifKhn

Copy link
Copy Markdown
Owner

Summary

  • Converts OnboardingScreen from StatefulWidget to ConsumerStatefulWidget
  • Replaces the raw StorageService() instantiation and manual init() call with ref.read(storageServiceProvider), consistent with every other screen in the app
  • Removes the now-unused storage_service.dart import and adds alarm_provider.dart

Root Cause

_OnboardingScreenState._next() was constructing a second StorageService instance and calling init() on it independently, which could race or diverge from the singleton managed by Riverpod.

Testing

  • flutter analyze --fatal-infos — zero issues
  • flutter test — all 30 tests pass
  • dart format — no changes needed

Closes #13

@vercel

vercel Bot commented Mar 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
drawbell Ready Ready Preview Aug 11, 2026 5:31am

@KashifKhn
KashifKhn merged commit 9954e38 into main Aug 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: OnboardingScreen instantiates raw StorageService instead of using provider

1 participant