fix(eval): Venue Booking merge uses customer field - #29
Merged
Conversation
Guest merge listed Venue Booking under guest, but the doctype links via customer — that aborted the harness transaction and flaked later POS checks. Skip missing link fields and isolate each eval check behind its own savepoint. Co-authored-by: Cursor <cursoragent@cursor.com>
MariaDB date(now()) is UTC; creation follows the site timezone. After 18:30 UTC on IST sites every fire reset to kot_no=1 and the eval assert flaked. Bound the max() query with frappe's today() instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guestcolumn; usecustomerand skip missing link fields.Test plan
75/75 passedMade with Cursor