Disabling Reels in Home feed and Reel scrolling from DM and bug fixes - #51
Open
IzhanAli wants to merge 1 commit into
Open
Disabling Reels in Home feed and Reel scrolling from DM and bug fixes#51IzhanAli wants to merge 1 commit into
IzhanAli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features:
Reels in home feed: stops reel posts playing and collapses them. The home Reels are collapsed to a measurable 0px box instead, which the feed can still account for.
Reel scrolling: locks the paged reel viewer, so a reel someone sends you can still be watched but no longer scrolled on from. The viewer is matched by structure, a scroller holding several videos whose direct children are each about one screen tall, rather than by class name. A chat message list is not built that way, so normal scrolling in chats is unaffected.
Bug fixes:
close #8 - A defaultValue only reaches SharedPreferences once its switch has been shown and changed, so a newly added setting stayed absent from the preferences and InjectionBuilder skipped its block until the user toggled it by hand. readAgain is set so that settings added by a later update are covered too, and it never overwrites a choice the user has already made.
Audio toggle issue is fixed