Add unit test and benchmark for mesh loading + BVH generation (#691) - #800
Draft
kimjune01 wants to merge 1 commit into
Draft
Add unit test and benchmark for mesh loading + BVH generation (#691)#800kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
…ngine#691) Implements the request from issue KaijuEngine#691 to create a unit test and benchmark for loading a mesh and generating its BVH structure. - TestKaijuMeshLoadAndGenerateBVH: validates that a loaded mesh can generate a BVH and correctly perform ray intersection queries - BenchmarkKaijuMeshLoadAndGenerateBVH: measures performance of deserializing a 50K vertex mesh and generating its BVH The test follows the existing pattern from TestKaijuMeshSerializePreservesBVH but adds explicit BVH generation and ray intersection validation.
kimjune01
marked this pull request as draft
May 22, 2026 21:28
Author
|
Cannot validate on current setup, so drafting. Please close or take it over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestKaijuMeshLoadAndGenerateBVHcovering the serialize-deserialize-BVH-RayIntersect roundtripBenchmarkKaijuMeshLoadAndGenerateBVHmeasuring combined deserialize + BVH generation on a 50K meshDeserializeper iteration to avoid cache distortionAddresses #691
Test plan
go test ./editor/cache/assets/loaders/kaiju_mesh/...passesgo test -bench=. ./editor/cache/assets/loaders/kaiju_mesh/...runs benchmarkgo vet ./...passes clean