Repository navigation
Document necessary reentrancy patterns with slither-disable - #29
Merged
Merged
Conversation
These functions require return values from external calls before emitting events: - UniswapV3Swap: all three swap functions need actual amounts - Call.callBySelector: needs actual return data - TryCatch: has noReentrancy guard, safe to emit after call All 945 tests passing. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add documentation comments for reentrancy patterns that are necessary and safe because they require return values from external calls before emitting events.
Changes
Test Plan