Repository navigation
Apply remaining Slither reentrancy fixes (CEI pattern) - #28
Merged
Merged
Conversation
…racts - Move event emissions before external calls in UniswapV4LimitOrder, MerkleAirdrop - Add missing OwnerChanged event to FunctionModifier.changeOwner() - Add noReentrancy guard to TryCatch.tryLowLevelCall() to prevent state changes after external calls - Restructure UniswapV4LimitOrder.createOrder() to emit event before transfer (CEI pattern) - Improve code safety by following check-effects-interactions pattern consistently Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Apply check-effects-interactions pattern consistently: - DutchAuction.endAuction() - TokenLocker.createLock() - SendingEther.sendViaCall() and sendSafely() - MinimalProxy.cloneWithInitialization() - TimeLock.execute() - MultiSigWallet.executeTransaction() - UniswapV2Swap.flashSwap() - MultiCall.multicall() All tests passing (945 tests). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Apply check-effects-interactions pattern to: - CrowdFund.unpledge() - CustomError.withdraw() - Payable.withdraw() and withdrawTo() - SendingEther.sendViaSend() - TokenLocker.withdraw() - UniswapV3Swap.swapExactInputSingle() All 945 tests passing. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies the remaining 3 commits from the original fix that didn't make it into PR #27. All changes follow the check-effects-interactions (CEI) pattern to prevent reentrancy vulnerabilities.
Fixes Applied:
Contracts Fixed:
Test Plan