Repository navigation
Sharpen small marks, fix layered logos, and release 0.4.0 - #4
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-launch pass over the registry primitive, the docs and the repo plumbing. Releases benday 0.4.0.
Install through the
@bendaynamespaceThe directory PR landed, so the command is now:
Verified against a bare consumer project: the namespace resolves with nothing in
components.json, all seven files land on their targets, and the installed files are byte-identical toregistry/ui/. README, the usage page and the four package-manager tabs updated. The launch video is deliberately untouched.One upstream quirk worth knowing: the CLI strips a file's leading comment, so
dom.tsandtypes.tslose their header on install. The payload still carries them.Rendering fixes
Two real bugs, measured on the actual pipeline rather than by eye.
Small marks rendered as haze. Every dot under 32px got a shadow blur for optical weight, even at
glow: 0. At 16px the blurred footprint was 1.6× the lattice pitch, so neighbouring dots bled into one continuous wash — plus a 0.2px vertical smear fromshadowOffsetY.Only
glowblurs now,shadowOffsetYis gone, the consolidation floor went 1.5px → 2px, and small lattices snap to whole device pixels. At 16px: 7×7 dots on an exact 2.00px pitch, no blur, footprint 0.76× pitch.Layered logos came out one solid layer and one faint one. The bake normalized each source to its own 8th–92nd percentile luminance and stretched it to a full 0..1, so any difference became the maximum difference — with a cliff where 17 levels of spread separated nothing and 19 separated everything.
#3b82f6+ red#ef4444, 19 levels apartTone is now applied in proportion to the separation the artwork actually has. Near-uniform artwork stays flat; genuinely layered artwork separates exactly as before.
Marks will look different after this change, and pre-baked
dotMaps keep their old tone until re-baked — both called out in the changeset.Tests are no longer stale
registry/tests/now runs in CI, between Typecheck and Unused code. Kept out ofregistry/ui/so that tree stays a clean mirror of what the CLI installs.Also gave
registryits owntypecheck. It had none — it was only checked incidentally throughapps/web's tsconfiginclude, and since turbo hashes inputs per package, registry edits never invalidatedweb:typecheckand it would replay a stale pass. Verified the new one isn't vacuous by planting a type error.New coverage for
bake.ts(641 lines, previously untested) via a stubbed canvas: mask selection, trimming, layered artwork in both directions, EDT depth normalization, threshold,dilate, and empty sources. 24 tests total. Three existing tests failed under the tone fix because they pinned the old over-stretched extremes — rewritten to assert proportion, with new guards for the equal-weight-inks case and the no-blur behaviour.Smaller things
bun run devno longer starts Remotion Studio. It filters toweb; the video stays behindbun run video:studio.DOT_COLORSlist — the home page and playground each had their own copy before.Checks
check,typecheck,test,knip, registry drift andbuildall pass locally.Worth a look before merge: the numbers say the lattice resolves now, but whether the mark still reads at 16px with 7×7 dots instead of 10×10 is a judgement call. The playground at small sizes and the agent preview at 28px are the places to check.
🤖 Generated with Claude Code
Summary by cubic
Sharpens small marks and fixes layered logo tone in
benday, with pixel-snapped lattices and a 2px auto-grid floor, and releases 0.4.0. Adds CI-backed tests, a long-running agent preview, and@benday/bendayinstall docs.Bug Fixes
glowblurs, no vertical shadow offset, auto-consolidation won’t go below 2px cells, and small lattices (and origins) snap to device pixels to avoid haze.dotMaps keep old tone until re-baked.New Features
@benday/benday; docs and usage updated.bun run devnow filters toweb; usebun run video:studiofor Remotion.registry/testsrun in CI; added bake and renderer coverage and a dedicatedregistrytypecheck.DOT_COLORS(adds Fuchsia and Sky; reordered swatches). Agent preview adds a long-running “Searching” mock with a shimmer label and elapsed timer.Written for commit 198069b. Summary will update on new commits.