Add the validate.yml PR workflow for changed ckans - #5
Open
Maximilian-Nesslauer wants to merge 1 commit into
Open
Add the validate.yml PR workflow for changed ckans#5Maximilian-Nesslauer wants to merge 1 commit into
Maximilian-Nesslauer wants to merge 1 commit into
Conversation
- Mirror KSP-CKAN/KSP2-CKAN-meta's validate.yml: run the xKAN-meta_testing action (game KSA, source commits) on pushes to main and on PRs, with the download cache step. - Runs fail until KSA client support is merged into upstream KSP-CKAN/CKAN, because the action executes the upstream-built kspckan/metadata image, which rejects --game KSA until then. Closes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/validate.yml, validating changed.ckanfiles with the CKAN metadata tester, the same PR/push check KSP-CKAN/KSP2-CKAN-meta and KSP-CKAN/CKAN-meta run.The file mirrors KSP2-CKAN-meta's
validate.yml; the only deltas are a one-line header comment andgame: KSA.Sequencing / expected red check
The
kspckan/metadataimage is built from upstream KSP-CKAN/CKAN and rejects--game KSAuntil the KSA client support is merged there, so the Validate check (including on this PR itself) fails until that deploy.This is the same gate documented in #4 and in the KSA-NetKAN workflow issue (KSAModding/KSA-NetKAN#2); merging before the gate lifts is fine, the check starts passing after the upstream deploy.
Closes #4.