Skip to content

KPMP 6721 do not slice#649

Merged
HaneenT merged 2 commits into
developfrom
KPMP-6721_do-not-slice
Jun 16, 2026
Merged

KPMP 6721 do not slice#649
HaneenT merged 2 commits into
developfrom
KPMP-6721_do-not-slice

Conversation

@Dert1129

@Dert1129 Dert1129 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Version updated to 3.4.0
  • Bug Fixes

    • Improved consistency in cell type summary data handling across all application states.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 353f3d0b-3b55-4be9-9b97-c72ff0fa2a6b

📥 Commits

Reviewing files that changed from the base of the PR and between 1442a55 and e2aadf5.

📒 Files selected for processing (2)
  • package.json
  • src/components/Summary/CellTypeSummary.js

Walkthrough

The fetchClusterHierarchy method in CellTypeSummary is updated to remove a conditional block that sliced results when featureSTData === false, so cellTypeSummary state is now always set from the full results array. The package version is bumped from 3.1.0 to 3.4.0.

Changes

CellTypeSummary Fix and Version Bump

Layer / File(s) Summary
Remove featureSTData results slice and version bump
src/components/Summary/CellTypeSummary.js, package.json
fetchClusterHierarchy drops the featureSTData === false branch that previously called .slice() on results before setState, so the full results array is used unconditionally. Package version updated from 3.1.0 to 3.4.0.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch KPMP-6721_do-not-slice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HaneenT HaneenT merged commit 48b6464 into develop Jun 16, 2026
1 check passed
@HaneenT HaneenT deleted the KPMP-6721_do-not-slice branch June 16, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants