Move the bus unit to the image, which can actually install it - #18
Merged
Conversation
systemd/waypoint-bus@.service sat here referenced by no nfpm.yaml, so no package carried it and no node ever received it. Every .deb this repository builds ships a daemon binary and nothing else — that is the stated design — which made this the one file here with no route to a node. It was also still on the pre-0.3 /home/pi-star paths for both its binary and its config, and had been since the state tree moved to /var/lib/waypoint. That survived review because it stays true by accident on a node migrated from a 0.2 image, where waypointd leaves a compatibility symlink at the old path; a node flashed from a current image has no such symlink. Both the unit and the waypoint-bus binary now ship with the image, where the gateway units already live and where something exists to install them. See KN4OQW/waypoint#109. Signed-off-by: Clint Chance <clintchance@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
systemd/waypoint-bus@.servicesat in this repository referenced by nonfpm.yaml, so no package carried it and no node ever received it. Every.debbuilt here ships a daemon binary and nothing else — the stated design, repeated in every packaging description — which made this the one file in the repo with no route to a node.It was also still on the pre-0.3
/home/pi-starpaths for both its binary and its config, and had been since the state tree moved to/var/lib/waypoint. That survived review because it stays true by accident on a node migrated from a 0.2 image, where waypointd leaves a compatibility symlink at the old path; a node flashed from a current image has no such symlink.Both the unit and the
waypoint-busbinary it names now ship with the Waypoint image, where the eleven gateway units already live and where something exists to install them. The binary was likewise never built by CI or published to a release — see KN4OQW/waypoint#109 and the companion PR KN4OQW/waypoint#232.Verification
Deletion plus a README correction; nothing here is built or tested. The claim that no package shipped this file is checkable by grep — no
packaging/*.nfpm.yamlreferenceswaypoint-busor asystemd/path. I have not run a package build on this branch.