Skip to content

Created Navigation for desktop and mobile. Added some styles.#16

Merged
KJHeartbreaker merged 3 commits into
mainfrom
navigation
Jun 5, 2025
Merged

Created Navigation for desktop and mobile. Added some styles.#16
KJHeartbreaker merged 3 commits into
mainfrom
navigation

Conversation

@KJHeartbreaker

Copy link
Copy Markdown
Owner

No description provided.

@KJHeartbreaker
KJHeartbreaker requested a review from Copilot June 5, 2025 07:53
@vercel

vercel Bot commented Jun 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dds-next-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 8:09am

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new responsive navigation system and updates global styling and font settings.

  • Adds EB Garamond and Oswald fonts to Tailwind and Next.js font config, and wires them into the root layout
  • Introduces PrimaryNavigation and MobileMenu components for desktop and mobile nav with dynamic data fetching
  • Overhauls global CSS with design tokens (colors, typography, utility classes) and updates header to use the new nav components

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
web/tailwind.config.ts Added oswald font family entry
web/app/layout.tsx Injected font CSS variables into <html> and adjusted section padding
web/app/globals.css Defined root CSS variables for colors, typography, and utilities
web/app/fonts.ts Configured Google fonts (EB Garamond, Oswald) via next/font/google
web/app/components/PrimaryNavigation.tsx New desktop nav component with dynamic fetch and link styling
web/app/components/MobileMenu.tsx New mobile menu with toggle button, focus trap, and animations
web/app/components/Logo.tsx Logo component rendering SVG and brand text
web/app/components/Header.tsx Header updated to compose Logo, PrimaryNavigation, MobileMenu
web/app/api/navigation/primary/route.ts API route added to fetch primary navigation data from Sanity
Comments suppressed due to low confidence (1)

web/app/components/MobileMenu.tsx:9

  • The NavMenuItem type and getHref function are duplicated from PrimaryNavigation. Extract them into a shared module or utility to prevent drift and reduce duplication.
type NavMenuItem = {

Comment thread web/app/components/PrimaryNavigation.tsx Outdated
Comment thread web/app/api/navigation/primary/route.ts Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@KJHeartbreaker
KJHeartbreaker merged commit c6058eb into main Jun 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants