Fix PowerFactory controller connection metadata - #25
Conversation
JohannesWeinbrecht
left a comment
JohannesWeinbrecht
left a comment
There was a problem hiding this comment.
I say we postpone this PR until it is properly tested with multiple exports.
I don't want to merge this into main, where we have a running importer (even though it is generating models with a slight issue).
| generic_avr.uid: generic_avr.connector_names.copy(), | ||
| self._component_dict[generator].uid: [], | ||
| } | ||
| ) |
There was a problem hiding this comment.
When trying to import the example IEEE 39 Grid from PowerFactory to GDF, this fails for me, with KeyError[really long object] is not in the graph.
I say we postpone this PR until it is properly tested with multiple exports.
I don't want to merge this into main, where we have a running importer (even though it is generating models with a slight issue).
There was a problem hiding this comment.
Reproduced the IEEE39 KeyError locally. The controller metadata was being updated before the corresponding graph edge existed, so I added the missing generator edges for AVR, governor, and PSS before updating the metadata.
Re-tested with the PowerFactory 39 Bus New England System: import now completes with 140 nodes / 147 edges and includes IEEET1, IEEEG1, and PTIST1 controller connections. I also smoke-tested the 14 Bus export. Core tests: 51 passed, 8 skipped.
|
Reproduced the IEEE39 KeyError locally. The controller metadata was being updated before the corresponding graph edge existed, so I added the missing generator edges for AVR, governor, and PSS before updating the metadata. Re-tested with the PowerFactory 39 Bus New England System: import now completes with 140 nodes / 147 edges and includes IEEET1, IEEEG1, and PTIST1 controller connections. I also smoke-tested the 14 Bus export. Core tests: 51 passed, 8 skipped. |
JohannesWeinbrecht
left a comment
JohannesWeinbrecht
left a comment
There was a problem hiding this comment.
LGTM, seems like it was a rather minor fix.
Regarding the models to replace in the repository, I am unsure what to do.
I converted the models I had (the one to be suspected to be the "clean" model from Moritz), but they show much larger diffs than this PR explains (like trafos having different names and some different parameters).
Maybe @AlexKocherKIT can help with the decision about the models.
3 participants
Fixes missing connector metadata for PowerFactory-imported generator controls.
Changes:
The controller components already existed, but their edge dictionaries did not contain the required connector names.
Tests:
powerfactoryPython module is not availableCloses #16