Draft: Kommon: Error when trying to convert KContainer to wrong type - #161
Open
2xB wants to merge 2 commits into
Open
Draft: Kommon: Error when trying to convert KContainer to wrong type#1612xB wants to merge 2 commits into
2xB wants to merge 2 commits into
Conversation
Before, this lead to an undiscovered issue where a configuration value was just not used since quite some time, compare KATRIN-Experiment#157 . Ideally this makes such issues obvious already in development when they first occur.
For reasons beyond me, initmsg(eError) is neither printed nor shows an error. Using runtime_error instead, which does actually fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, this lead to an undiscovered issue where a configuration value was just not used since quite some time, compare #157 . Ideally this makes such issues obvious already in development when they first occur.
I already noticed just by running a random example that
KZonalHarmonicParameters::SetNCentralCoefficients(unsigned int)in the bindings is set to getint. So this verbose error instead of a silent fail is helpful and we need to look into what else errors now.Marked this as a draft since I believe we first should find as many problematic bindings as possible and only then merge this.
It would just be awesome if the runtime error would be augmented with information on which element is currently processed to debug this more easily.