docs: soften tiny oracle self-test expectation#511
Conversation
|
Thanks for this, and for approaching it from the honesty angle rather than just filing a complaint β a docs claim that overstates what the code does is a real defect, and #482 raised a legitimate one. I approved the workflows (they were held because this is your first PR here β my oversight, not yours) and I also ran the gate myself before answering, because I didn't want to weaken a headline claim on a single datapoint: gcc -O3 -march=native, x86-64 Linux, current dev. 32/32. So "typically 30-32/32" doesn't match the reference build β on it, the claim as written is exactly true. @woolcoxm's 30/32 in #482 is real too, and the near-tie explanation is almost certainly right, but it's toolchain-specific rather than typical. Two things also worth knowing: So I'd like to keep the strength and add the condition, rather than downgrade the claim. Something like:
That tells a reader both true things: the engine is token-exact where we measure it, and here is the honest caveat with a pointer to the evidence. "Typically 30-32" tells them we're unsure, which isn't what the measurements say. Would you rework it along those lines? Happy to take it either as an update here or to keep discussing the wording β and if you can reproduce 30/32 on a mainstream toolchain, that changes my mind and I'd rather know. |
|
Heads-up: this now conflicts, and it's my doing β #521 rewrote the "Get started" sections of README.md and the quickstart a few hours ago, which is exactly where your changes land. Sorry for moving the ground under an open PR. The substantive question from my previous comment still stands (I measure 32/32 on the reference build, so "typically 30-32/32" doesn't match what the gate actually reports), so if you rebase, it's worth folding both in at once: rebase onto current If the rebase is annoying, say so and I'll take the wording from here and credit you β you found a real gap between what we claim and what we verify, and that shouldn't be lost to a merge conflict. |
|
Reminder that this still needs a rebase β my #521 rewrote the same README/quickstart sections, so it conflicts. The substance (softening the oracle claim) I'd still like to fold in, but with the wording we discussed: keep "token-exact 32/32 on the reference build" and add the near-tie caveat + #482 pointer, rather than downgrading to "typically 30-32". If the rebase is a hassle, say so and I'll take the wording from here with credit to you. |
Summary
Soften the tiny-oracle self-test wording from a hard 32/32 expectation to the maintainer-confirmed ~30-32/32 range when floating-point near-ties flip top-1 on some toolchains.
Validation
make checkmake -C c cuda-test(if applicable)Compatibility
Closes #482