Folia Support & Begone Whitespaces - #207
Open
R00tB33rMan wants to merge 3 commits into
Open
Conversation
Author
|
Hey @JustBru00, it has been a while since I've opened this PR. Any news on when it'll be merged? |
Owner
Hey @R00tB33rMan, I need to spend some time reviewing the PR. I did a quick skim of it a couple of months ago and I remember that there were a couple of changes that will break how the plugin used to work. I need to look through it again because I can't remember off the top of my head what those issues were. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Folia support. Folia support for EpicRename was straightforward, since all schedulers present are either for metrics or require a delayed response. This PR supports the same set of versions as upstream, including the base Spigot.
One thing I could not include in this PR was renaming the repository. I think it'd be more fitting to name it after the plugin, "EpicRename."