fix: block Junos command abbreviations from bypassing block.cmd - #33
Open
Venkata-Sai-Vishwanath-robo wants to merge 1 commit into
Open
fix: block Junos command abbreviations from bypassing block.cmd#33Venkata-Sai-Vishwanath-robo wants to merge 1 commit into
Venkata-Sai-Vishwanath-robo wants to merge 1 commit into
Conversation
check_command_blocklist matched the literal spelling of block.cmd patterns via a whole-string regex, but Junos accepts any unambiguous prefix abbreviation of a CLI keyword (and is case-insensitive), so e.g. "req sys reboot" reached the device unblocked while "request system reboot" was rejected. Matching is now token-wise, treating each pattern token as a case-insensitive Junos-style prefix abbreviation.
Venkata-Sai-Vishwanath-robo
marked this pull request as draft
August 10, 2026 21:12
Venkata-Sai-Vishwanath-robo
marked this pull request as ready for review
August 11, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_command_blocklist matched the literal spelling of block.cmd patterns via a whole-string regex, but Junos accepts any unambiguous prefix abbreviation of a CLI keyword (and is case-insensitive), so e.g. "req sys reboot" reached the device unblocked while "request system reboot" was rejected. Matching is now token-wise, treating each pattern token as a case-insensitive Junos-style prefix abbreviation.