Skip to content

Added docstrings to exported functions!#547

Merged
iblislin merged 4 commits into
JuliaStats:masterfrom
anurag-mds:doc-branch
Dec 31, 2025
Merged

Added docstrings to exported functions!#547
iblislin merged 4 commits into
JuliaStats:masterfrom
anurag-mds:doc-branch

Conversation

@anurag-mds

Copy link
Copy Markdown
Contributor

This PR addresses issue #533 by ensuring that all exported methods in TimeSeries.jl have comprehensive docstrings.

The following actions were taken:

Reviewed all exported functions, types, and constants.
Added or improved docstrings for any missing or incomplete documentation.
Followed the existing documentation style for consistency.
Included examples where helpful.

Motivation:
Having complete docstrings for all exported methods improves usability and discoverability for users, making the package easier to use and understand.
Notes:
All existing tests are passing. No change was done to code just documentation-only fixes were done.
Reviewers:
@ValentinKaisermayer @iblislin

@anurag-mds anurag-mds marked this pull request as ready for review December 29, 2025 11:23
@anurag-mds

Copy link
Copy Markdown
Contributor Author

@ValentinKaisermayer and @iblislin
When you have time, I’d appreciate a review. This PR is documentation-only and addresses #533.

@ValentinKaisermayer ValentinKaisermayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor comments.

Comment thread src/apply.jl
Comment thread src/combine.jl
@codecov-commenter

codecov-commenter commented Dec 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.45%. Comparing base (3291223) to head (cf18628).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   85.44%   85.45%   +0.01%     
==========================================
  Files          11       13       +2     
  Lines         625      887     +262     
==========================================
+ Hits          534      758     +224     
- Misses         91      129      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anurag-mds

Copy link
Copy Markdown
Contributor Author

@ValentinKaisermayer It's done kindly review it and if there are any more changes to notice and fix then please do let me know!

@iblislin

Copy link
Copy Markdown
Collaborator

maybe some of the docstring could be shared in the doc/?
I'm fine to merge this PR first, then we can work on putting/sharing them in doc/

@iblislin iblislin merged commit 1dfdd51 into JuliaStats:master Dec 31, 2025
4 checks passed
@iblislin

Copy link
Copy Markdown
Collaborator

Thanks for your contributions.

@anurag-mds

Copy link
Copy Markdown
Contributor Author

Thank you @iblislin
I am currently doing what you said i.e. sharing/putting them inside doc directory

@ValentinKaisermayer

Copy link
Copy Markdown
Contributor

Shouldn't Documenter.jl put them there automatically?

@iblislin

iblislin commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

Shouldn't Documenter.jl put them there automatically?

well, no. since there aren't any docstrings before, they aren't included in doc/.

@ValentinKaisermayer

Copy link
Copy Markdown
Contributor

Shouldn't Documenter.jl put them there automatically?

well, no. since there aren't any docstrings before, they aren't included in doc/.

Maybe we should add an API section like this

# API Documentation
```@autodocs
Modules = [TimeSeries]

@anurag-mds anurag-mds deleted the doc-branch branch February 27, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants