Skip to content

Switch CI to github actions and remove Travis#199

Merged
kleinschmidt merged 11 commits into
masterfrom
dfk/gh-ci
Dec 2, 2020
Merged

Switch CI to github actions and remove Travis#199
kleinschmidt merged 11 commits into
masterfrom
dfk/gh-ci

Conversation

@kleinschmidt

Copy link
Copy Markdown
Member

No description provided.

@palday palday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure on Future looks genuine.

While you're changing CIs, why not add

      - uses: julia-actions/julia-docdeploy@latest

to your Documentation CI? Then you can preview documentation builds. (This is what we're using in MixedModels to preview docs.)

@kleinschmidt

Copy link
Copy Markdown
Member Author

I think the future failure is a change in how the small p value exponents are printing in the F/LR test tables (similar thing cropping up in GLM...):

on nightly:

Likelihood-ratio test: 2 models fitted on 4 observations
──────────────────────────────────────────────
     DOF  ΔDOF  Deviance  ΔDeviance  p(>Chisq)
──────────────────────────────────────────────
[1]    0         30.0000                      
[2]    1     1   10.8600   -19.1400     <1e-04
──────────────────────────────────────────────

tests expect:

Likelihood-ratio test: 2 models fitted on 4 observations
──────────────────────────────────────────────
     DOF  ΔDOF  Deviance  ΔDeviance  p(>Chisq)
──────────────────────────────────────────────
[1]    0         30.0000                      
[2]    1     1   10.8600   -19.1400      <1e-4
──────────────────────────────────────────────

@kleinschmidt

Copy link
Copy Markdown
Member Author

What happened here is that Printfageddon (JuliaLang/julia#32859) also fixed a few bugs/inconsistencies julia's @printf. The 04 two-digit format for small pvalue exponents was always intended. StatsBase.jl put the p value printing behind a version check (JuliaStats/StatsBase.jl#606).

@@ -0,0 +1,47 @@
name: CI-future

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what's the advantage of using a separate workflow for nightlies?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep that sweet sweet green badge even when things go sideways on nighly

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good idea. We could do that in DataFrames too, and in the PR I opened against Example.jl.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, less cheekily, to be able to see at a glance if any of the stable releases have failing tests AND whether nightly has failing tests, since those indicate different types of problems (only the first should block merging IMO, but we can't afford to ignore the second so we don't want to use continue-on-error and nighly failures green...).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I learned this trick from the MixedModels CI which has been on actions for a while now...

Comment thread .github/workflows/ci.yml
@kleinschmidt

Copy link
Copy Markdown
Member Author

I can reproduce nightly failure on latest nightlies but it does not appear to be related to anything here...happens when trying to instantiate the project.

@kleinschmidt
kleinschmidt merged commit bdc935f into master Dec 2, 2020
@nalimilan
nalimilan deleted the dfk/gh-ci branch December 3, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants