Add pre-sorting of levels to RFP#906
Merged
Merged
Conversation
dmbates
reviewed
Jul 21, 2026
| spL = sparseL(fm1) | ||
| @test size(spL) == (4114, 4114) | ||
| @test 733090 < nnz(spL) < 733100 | ||
| # nnz(spL) counts the exact zeros remaining in the (densely stored) filled |
Collaborator
There was a problem hiding this comment.
Don't you mean that nnz(spL) counts the non-zeros?
Collaborator
|
I am getting a test failure of |
Member
Author
Interesting. That's not the best test, but I've loosened the tolerances and kept it in for now (2c230e6). That test is supposed to test the simulation code and show that we get similar-ish parameter estimates when we fit a model on simulated data. I've set the tolerance to |
dmbates
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned out to be less difficult than I originally thought.