Fix slow changelog generation for historical releases#582
Merged
Conversation
Fixes #578 `_previous_release_chronological` looped over every tag and made a `get_release` API call (404 for most) plus a `git log` subprocess per tag. On a registry with hundreds of tags this took minutes (~289s for 639 tags), neither of which was reflected in the API-call perf counter. Add `Git.commit_times_of_tags`, which resolves every tag's underlying commit datetime in a single `git for-each-ref` call (handling both lightweight and annotated tags), and use it for the chronological predecessor lookup with a single-tag fallback for tags missing from the batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578
Claude:
_previous_release_chronologicallooped over every tag and made aget_releaseAPI call (404 for most) plus agit logsubprocess per tag. On a registry with hundreds of tags this took minutes (~289s for 639 tags), neither of which was reflected in the API-call perf counter.Add
Git.commit_times_of_tags, which resolves every tag's underlying commit datetime in a singlegit for-each-refcall (handling both lightweight and annotated tags), and use it for the chronological predecessor lookup with a single-tag fallback for tags missing from the batch.