AlgoimDiff to point to updated c++ repo#14043
Conversation
Point toward an updated version of the c++ source
Pointed to updated c++ commit.
I have had to severely limit the platforms supported, because the build system cannot find the jlcxx.hpp header on many systems.
| ) | ||
| platforms = expand_cxxstring_abis(platforms) | ||
| filtered_platforms = filter(supported_platforms()) do p | ||
| Sys.islinux(p) && arch(p) == "x86_64" |
There was a problem hiding this comment.
you are quite drastically reducing the number of platforms here. Is that intended? For example x86_64-apple-darwin used to be supported but is no longer
There was a problem hiding this comment.
Unfortunately it was intentional. For many platforms, the current script in build_tarballs.jl is unable to find the directories where the CxxWrap headers are (e.g.jlcxx.hpp). I am not sure what changed. I spent many hours looking through other packages that use CxxWrap to find workarounds without success.
There was a problem hiding this comment.
Hi @lgoettgens, do I need to resolve this converstation?
There was a problem hiding this comment.
I am not happy with this hard of a platform restriction in a minor version bump, which is why I haven't approved this. If you find another yggdrasil maintainer that merges this PR as is, that is an ok solution for me.
Otherwise, you could enable more platforms again (ideally all that should in theory be supported) and have people here help you with debugging.
One thing that I see immediately is that since you rely on libjulia and libcxxwrap, you need to do a separate build per julia minor release. Otherwise, your package will probably not work properly due to ABI differences between different julia versions. Please have a look at other recipes depending on libcxxwrap (e.g. Geant4_julia) for a blueprint on how to do that.
There was a problem hiding this comment.
Yes. And it's not clear to me why the header files shouldn't be found.
There was a problem hiding this comment.
@lgoettgens and @giordano: Ok, I will take another crack at this if and when I find time.
3 participants
This is a simple update to the commit in the
sourcesvariable of thebuild_tarballs.jlfile. I also updated the version.