Remove ini_hex, ini_HEX#125
Merged
Merged
Conversation
Printf no longer uses ini_hex and ini_HEX Removed in "Rewrite printf functionality" #32859
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 45.86% 45.86%
=======================================
Files 63 63
Lines 3203 3203
=======================================
Hits 1469 1469
Misses 1734 1734
Continue to review full report at Codecov.
|
Member
|
yes -- thank you Greg. |
ToucheSir
added a commit
to ToucheSir/BFloat16s.jl
that referenced
this pull request
Jan 4, 2022
Ref. JuliaLang/julia#32859, JuliaMath/DoubleFloats.jl#125. This is causing warnings downstream in CUDA.jl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When precompiling
DoubleFloats, I'm getting this warning:Firstly, I don't really understand this code.
But it seems
ini_hexandini_HEXare not used in this file (src/type/show.jl).Also it seems
Printfno longer usesini_hexandini_HEX.I think they were removed in "Rewrite printf functionality" #32859