[JuliaLowering] Add precompile workload for generators, kwargs, etc.#62306
Conversation
This is enough to dramatically reduce the lowering time for StaticArrays.jl and IntervalArithmetic.jl.
mlechu
left a comment
mlechu
left a comment
There was a problem hiding this comment.
Merge if it helps your workflow. I probably precompile more often than I use this code, but can easily revert it locally if it becomes a problem.
| _precompile_usemac(3) | ||
| _precompile_genf(1.0) | ||
| """ | ||
| include_string(@__MODULE__, workload, @__FILE__) |
There was a problem hiding this comment.
I think it would also be fine to migrate the thunks code above to the include_string approach.
There was a problem hiding this comment.
I'm going to merge this as-is, since tweaks would need a re-measurement and PkgEval seems pretty happy with this configuration (we are <~2x flisp to lower most packages w/ #62302 - only a couple of poorly scaling exceptions)
|
|
|
@topolarity this appears to have failed on CI on master |
merge conflict w/ #62221 (sort of) - just merged #62302 to fix it |
4 participants
@mlechu We may want to gate this on
DEBUG, but this improves lowering time from ~20+ seconds to 0.53 s on a similar test package (StaticArrays / IntervalArithmetic are the motivation)