Conversation
When a macro accepts a `Core.MacroSource` argument (e.g. `@VERSION`) and the first method lookup succeeds, `margs[1]` remains a `MacroSource` rather than the inner `LineNumberNode`. Passing it to `jl_timing_show_macro` then trips an assertion in assertions builds. Use the already-unwrapped `retry_lno` for the timing call when available. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hardikxk
pushed a commit
to hardikxk/julia
that referenced
this pull request
May 18, 2026
When a macro accepts a `Core.MacroSource` argument (e.g. `@VERSION`) and the first method lookup succeeds, `margs[1]` remains a `MacroSource` rather than the inner `LineNumberNode`. Passing it to `jl_timing_show_macro` then trips an assertion in assertions builds. Use the already-unwrapped `retry_lno` for the timing call when available. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
May 22, 2026
When a macro accepts a `Core.MacroSource` argument (e.g. `@VERSION`) and the first method lookup succeeds, `margs[1]` remains a `MacroSource` rather than the inner `LineNumberNode`. Passing it to `jl_timing_show_macro` then trips an assertion in assertions builds. Use the already-unwrapped `retry_lno` for the timing call when available. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a macro accepts a
Core.MacroSourceargument (e.g.@VERSION) and the first method lookup succeeds,margs[1]remains aMacroSourcerather than the innerLineNumberNode. Passing it tojl_timing_show_macrothen trips an assertion in assertions builds. Use the already-unwrappedretry_lnofor the timing call when available.This was introduced by #60018 (cc @Keno).
Fixes assertion seen locally:
Requires assertions + timings to be enabled (e.g.
WITH_TRACY=1), which presumably explains whygnuassertdidn't catch this.