Skip to content

Continue improving operator documentation#61127

Merged
fingolfin merged 4 commits into
JuliaLang:masterfrom
rokke-git:rokke-git-patch-1
Feb 25, 2026
Merged

Continue improving operator documentation#61127
fingolfin merged 4 commits into
JuliaLang:masterfrom
rokke-git:rokke-git-patch-1

Conversation

@rokke-git

Copy link
Copy Markdown
Contributor

I've bumped my head against this section of the documentation quite a number of times (#61055, #60928, #58763), but it looks like I just missed a pr which massively improved it (#60286). While it caught a number of things I wanted fixed, there are still some tweaks which should be added for correctness.

changes:

  • consolidates duplicated juxtaposition note
  • corrects the straight up wrong ordering of ' and ::
  • adds ... and , and -> and unary :
  • adds footnotes for a number of exceptions relating to various operators
    • . and : must have no spaces
    • :, .., ' cannot be dot-distributed
    • : parses into groups of three
    • 2-argument ~ is not defined in main
    • ?: precedence is asymmetric
    • assignment operators get weird with commas

pinging @moble who did the previous pr

@adienes
adienes requested a review from fingolfin February 23, 2026 02:53
@rokke-git
rokke-git force-pushed the rokke-git-patch-1 branch 6 times, most recently from 716ff33 to 24f738b Compare February 23, 2026 03:31
Comment thread doc/src/manual/mathematical-operations.md Outdated
Comment thread doc/src/manual/mathematical-operations.md Outdated
@rokke-git

Copy link
Copy Markdown
Contributor Author

it would prob also be good to fix the [above](@ref Chaining-comparisons) link. I suspect it's broken because it's a third-level instead of second-level heading; but idk juliadoc markdown well enough to know what the correct format to link to a third-level heading is.

@fingolfin

Copy link
Copy Markdown
Member

I'll look closer into this tonight or tomorrow

Comment thread doc/src/manual/mathematical-operations.md
Comment thread doc/src/manual/mathematical-operations.md Outdated
Comment thread doc/src/manual/mathematical-operations.md Outdated
Comment thread doc/src/manual/mathematical-operations.md Outdated
Comment thread doc/src/manual/mathematical-operations.md Outdated
@rokke-git
rokke-git force-pushed the rokke-git-patch-1 branch 3 times, most recently from 314c778 to c0a6e69 Compare February 24, 2026 05:29
@rokke-git
rokke-git requested a review from fingolfin February 24, 2026 05:33
@rokke-git
rokke-git force-pushed the rokke-git-patch-1 branch 2 times, most recently from ea04e55 to 431ef44 Compare February 24, 2026 05:52
@fingolfin fingolfin added the docs This change adds or pertains to documentation label Feb 25, 2026

@fingolfin fingolfin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fingolfin
fingolfin merged commit 73639be into JuliaLang:master Feb 25, 2026
9 checks passed
@moble

moble commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Nice work. Thanks @rokke-git!

mkitti pushed a commit to mkitti/julia that referenced this pull request May 22, 2026
I've bumped my head against this section of the documentation quite a
number of times (JuliaLang#61055, JuliaLang#60928, JuliaLang#58763), but it looks like I just
missed a pr which massively improved it (JuliaLang#60286). While it caught a
number of things I wanted fixed, there are still some tweaks which
should be added for correctness.

changes:  
 - consolidates duplicated juxtaposition note
 - corrects the straight up wrong ordering of `'` and `::`
 - adds `...` and `,` and `->` and unary `:`
- adds footnotes for a number of exceptions relating to various
operators
   - `.` and `:` must have no spaces
   - `:`, `..`, `'` cannot be dot-distributed
   - `:` parses into groups of three
   - 2-argument `~` is not defined in main
   - `?:` precedence is asymmetric
   - assignment operators get weird with commas

pinging @moble who did the previous pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants