runtests: prefix with the testsuite and worker number#60372
Open
IanButterworth wants to merge 2 commits into
Open
runtests: prefix with the testsuite and worker number#60372IanButterworth wants to merge 2 commits into
IanButterworth wants to merge 2 commits into
Conversation
Member
|
What am I looking for as a difference |
Member
Author
|
It's not currently working Should look like |
Member
Author
Member
Author
|
I think it's looking good, but not sure if the changes to Distributed are the best way to do it i.e. via a global hook.. |
IanButterworth
force-pushed
the
ib/runtests_prefix
branch
from
December 12, 2025 21:01
2c97cc6 to
77d6444
Compare
IanButterworth
marked this pull request as ready for review
December 18, 2025 03:24
IanButterworth
force-pushed
the
ib/runtests_prefix
branch
from
December 18, 2025 03:34
77d6444 to
6661852
Compare
Member
Author
|
@JamesWrigley would you mind reviewing this and JuliaLang/Distributed.jl#157 |
Member
|
Sure, will try to give it a look over the weekend 👍 |
Member
Author
|
@JamesWrigley did you have any feedback on this? thanks |
Member
|
My apologies, I forgot 🙈 Will take a look tomorrow. |
JamesWrigley
requested changes
Jan 15, 2026
JamesWrigley
left a comment
JamesWrigley
left a comment
Member
There was a problem hiding this comment.
My apologies, I forgot 🙈 Will take a look tomorrow.
In my defense I had food poisoning last week 🤣
Label each line of a test worker's output with the test it is currently running instead of just its worker id, making it much easier to tell which suite a stray log line or precompile message came from. Worker output is routed through Distributed, so an internal `Distributed.worker_output_hook` is installed that transforms each line into a de-emphasized `"<test> (<worker>): "` prefix (falling back to the worker id when the worker is between tests). The node-1 tests run in-process and do not pass through that redirection, so their stdout/stderr are captured with a `Pipe` and prefixed the same way via `with_output_prefix`. Prefixes are styled with `StyledStrings` so they are only colorized on IOs that support it. The embedding test is updated for the reduced single-space default worker prefix introduced in the corresponding Distributed change. Depends on JuliaLang/Distributed.jl#157. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Point the bundled Distributed at JuliaLang/Distributed.jl#157, which adds the internal `worker_output_hook` used by the test harness. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
IanButterworth
force-pushed
the
ib/runtests_prefix
branch
from
July 16, 2026 15:05
30de043 to
63d1d8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on JuliaLang/Distributed.jl#157
Shows the test suite name as the output prefix to make it easier to figure out which test it came from
https://buildkite.com/julialang/julia-master/builds/52736#019b13f7-46fa-4266-8d65-b785869b9c06/954-1074