Update CONTRIBUTING.md to 100 line-length limit (and grammar)#49869
Closed
PallHaraldsson wants to merge 1 commit into
Closed
Update CONTRIBUTING.md to 100 line-length limit (and grammar)#49869PallHaraldsson wants to merge 1 commit into
PallHaraldsson wants to merge 1 commit into
Conversation
Contributor
Author
|
I thought of this seeing comment length mentioned here (and the guide is silent on that detail): I looked up what's common, and The Google Java styleguide is at 100 letters for some reason (and the Linux kernel still in the past at 80 max.). I'm thinking, we want the shortest vertical space, lines of code possible for functions and modules. But I couldn't find any styleguides mentioning some max there. [And for each individual line, maybe it's best the line excluding whitespace indent is much smaller than 80 letters, but no need to mention that.] |
Member
|
Why would you want this? It would make it more difficult to have multiple Julia source code tabs open simultaneously. |
Member
|
There doesn't seem to be a strong reason to suddenly change this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]