Skip to content

Update CONTRIBUTING.md to 100 line-length limit (and grammar)#49869

Closed
PallHaraldsson wants to merge 1 commit into
JuliaLang:masterfrom
PallHaraldsson:patch-11
Closed

Update CONTRIBUTING.md to 100 line-length limit (and grammar)#49869
PallHaraldsson wants to merge 1 commit into
JuliaLang:masterfrom
PallHaraldsson:patch-11

Conversation

@PallHaraldsson

Copy link
Copy Markdown
Contributor

[skip ci]

@PallHaraldsson

PallHaraldsson commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

I thought of this seeing comment length mentioned here (and the guide is silent on that detail):
#49749 (comment)

I looked up what's common, and The Google Java styleguide is at 100 letters for some reason (and the Linux kernel still in the past at 80 max.).

I'm thinking, we want the shortest vertical space, lines of code possible for functions and modules. But I couldn't find any styleguides mentioning some max there. [And for each individual line, maybe it's best the line excluding whitespace indent is much smaller than 80 letters, but no need to mention that.]

@nsajko

nsajko commented May 18, 2023

Copy link
Copy Markdown
Member

Why would you want this? It would make it more difficult to have multiple Julia source code tabs open simultaneously.

@KristofferC

Copy link
Copy Markdown
Member

There doesn't seem to be a strong reason to suddenly change this.

@KristofferC KristofferC closed this Jul 5, 2023
@PallHaraldsson
PallHaraldsson deleted the patch-11 branch February 1, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants