Skip to content

Change timeout kill signals to SIGQUIT from SIGTERM #45864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
staticfloat wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Draft

Change timeout kill signals to SIGQUIT from SIGTERM #45864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LibGit2/test/libgit2-tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function challenge_prompt(cmd::Cmd, challenges)
end

if process_running(p)
kill(p)
kill(p, Base.SIGQUIT)
put!(timer, :timeout)
elseif success(p)
put!(timer, :success)
Expand Down
4 changes: 2 additions & 2 deletions stdlib/Profile/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ let cmd = Base.julia_cmd()
t = Timer(120) do t
# should be under 10 seconds, so give it 2 minutes then report failure
println("KILLING debuginfo registration test BY PROFILE TEST WATCHDOG\n")
kill(p, Base.SIGTERM)
kill(p, Base.SIGQUIT)
sleep(10)
kill(p, Base.SIGKILL)
end
Expand Down Expand Up @@ -202,7 +202,7 @@ if Sys.isbsd() || Sys.islinux()
t = Timer(120) do t
# should be under 10 seconds, so give it 2 minutes then report failure
println("KILLING siginfo/sigusr1 test BY PROFILE TEST WATCHDOG\n")
kill(p, Base.SIGTERM)
kill(p, Base.SIGQUIT)
sleep(10)
kill(p, Base.SIGKILL)
close(notify_exit)
Expand Down
2 changes: 1 addition & 1 deletion stdlib/Sockets/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function killjob(d)
ccall(:uv_kill, Cint, (Cint, Cint), getpid(), SIGINFO)
sleep(5) # Allow time for profile to collect and print before killing
end
ccall(:uv_kill, Cint, (Cint, Cint), getpid(), Base.SIGTERM)
ccall(:uv_kill, Cint, (Cint, Cint), getpid(), Base.SIGQUIT)
nothing
end
sockets_watchdog_timer = Timer(t -> killjob("KILLING BY SOCKETS TEST WATCHDOG\n"), 600)
Expand Down
2 changes: 1 addition & 1 deletion test/threads.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ cmd = """
sleep(100)
isopen(stdin) || exit()
println(stderr, "ERROR: Killing threads test due to watchdog expiry")
ccall(:uv_kill, Cint, (Cint, Cint), $(getpid()), Base.SIGTERM)
ccall(:uv_kill, Cint, (Cint, Cint), $(getpid()), Base.SIGQUIT)
"""
proc = open(pipeline(`$(Base.julia_cmd()) -e $cmd`; stderr=stderr); write=true)

Expand Down