Convert last_byte(stream) to Int in core_parser_hook#612
Merged
mlechu merged 1 commit intoDec 19, 2025
Merged
Conversation
fatteneder
approved these changes
Dec 19, 2025
aviatesk
approved these changes
Dec 19, 2025
Julia's `jl_parse` will type check the second element of the SimpleVector returned from core_parser_hook against `Int`. On newer JuliaSyntax, `last_byte(::ParseStream)` returns Int, but on 1.12, it returns UInt32 on 32 bit platforms, causing `jl_parse` to fail.
mlechu
force-pushed
the
core-parser-offset-type
branch
from
December 19, 2025 22:55
fd68396 to
5cbfebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia's
jl_parsewill type check the second element of the SimpleVector returned from core_parser_hook againstInt. On newer JuliaSyntax,last_byte(::ParseStream)returns Int, but on 1.12, it returns UInt32 on 32 bit platforms, causingjl_parseto fail. Fixes JuliaLang/julia#60417.