Skip to content

refactor: redundant lex in lex_less#585

Closed
anqur wants to merge 1 commit into
JuliaLang:mainfrom
anqur:refactor/lex_less
Closed

refactor: redundant lex in lex_less#585
anqur wants to merge 1 commit into
JuliaLang:mainfrom
anqur:refactor/lex_less

Conversation

@anqur

@anqur anqur commented Aug 22, 2025

Copy link
Copy Markdown

There's a redundant accept found in lex_less while lexing <--> or <-- related operators.

There's a redundant `accept` found in `lex_less` while lexing `<-->`
or `<--` related operators.

Signed-off-by: Anqur Lu <anqurvanillapy@gmail.com>
@c42f

c42f commented Nov 20, 2025

Copy link
Copy Markdown
Member

Heya, we just moved JuliaSyntax into Base in JuliaLang/julia#59870 - if you want to re-propose this PR over there, I've created a branch https://github.com/JuliaLang/JuliaSyntax.jl/tree/pr-for-Base/585 to make this easier.

To make use of the branch, you can use the following steps:

  • Clone JuliaLang/julia
  • Add JuliaSyntax as a git remote
  • Check out pr-for-Base/585
  • Rebase on top of master

For example:

# git clone git@github.com:JuliaLang/julia julia_dir
# cd julia_dir

git remote add JuliaSyntax git@github.com:JuliaLang/JuliaSyntax.jl
git fetch JuliaSyntax
git checkout pr-for-Base/585
git rebase origin/master

Sorry this wasn't dealt with prior to the big move!

@anqur anqur closed this Nov 25, 2025
@anqur
anqur deleted the refactor/lex_less branch November 25, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants