Fix non-DataType parameters in ABI exporter#148
Merged
Conversation
Member
|
Could you rebase? but lgtm |
This adds a test that fails on main: `CArrayN{T, N}` where `N` is an
`Int`.
Member
Author
|
Done |
Member
Author
|
Thanks @gbaraldi. I'll need a new release in order to merge JuliaInterop/JuliaLibWrapping.jl#31 and then JuliaInterop/JuliaLibWrapping.jl#41. Then I can push my upcoming whole-pipeline tutorial which will illustrate what I hope are the last hurdles to making this happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a few-line change, but it is built on top of #147 so it appears bigger than it is.
The part specific to this PR is the final two commits, the first adding a test that fails on the (post-147)
main, and the second the fix. Fine to squash when merging, I just kept them separate in case you wanted to verify the failure yourself.