Skip to content

Fix JET errors regarding the global cluster_manager being defined/undefined #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DilumAluthge wants to merge 1 commit into from
Closed

Fix JET errors regarding the global cluster_manager being defined/undefined #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/process_messages.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,12 @@ function handle_msg(msg::ResultMsg, header, r_stream, w_stream, version)
end

function handle_msg(msg::IdentifySocketMsg, header, r_stream, w_stream, version)
# We know that the global `Distributed.cluster_manager` is defined, because it was defined
# in the `init_worker(...)` function.
@assert isdefined(Distributed, :cluster_manager) # fixes a JET warning

# register a new peer worker connection
w = Worker(msg.from_pid, r_stream, w_stream, cluster_manager; version=version)::Worker
w = Worker(msg.from_pid, r_stream, w_stream, Distributed.cluster_manager; version=version)::Worker
send_connection_hdr(w, false)
send_msg_now(w, MsgHeader(), IdentifySocketAckMsg())
notify(w.initialized)
Expand All @@ -328,8 +332,12 @@ function handle_msg(msg::IdentifySocketAckMsg, header, r_stream, w_stream, versi
end

function handle_msg(msg::JoinPGRPMsg, header, r_stream, w_stream, version)
# We know that the global `cluster_manager` is defined, because it was defined
# in the `init_worker(...)` function.
@assert isdefined(Distributed, :cluster_manager) # fixes a JET warning

LPROC.id = msg.self_pid
controller = Worker(1, r_stream, w_stream, cluster_manager; version=version)::Worker
controller = Worker(1, r_stream, w_stream, Distributed.cluster_manager; version=version)::Worker
notify(controller.initialized)
register_worker(LPROC)
topology(msg.topology)
Expand Down