Fix some JET errors around matching methods for kill(...) and process_exited(...)#172
Merged
Merged
Conversation
…ess_exited(...)`
```
│┌ manage(manager::Distributed.LocalManager, id::Int64, config::Distributed.WorkerConfig, op::Symbol) @ Distributed /workpath/Distributed.jl/src/managers.jl:529
││ no matching method found `kill(::Nothing, ::Int64)` (1/2 union split): Distributed.kill((config::Distributed.WorkerConfig).process::Union{Nothing, Base.Process}, 2)
│└────────────────────
```
```
│┌ (::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig})() @ Distributed /workpath/Distributed.jl/src/managers.jl:757
│ no matching method found `kill(::Nothing, ::Int64)` (1/2 union split): Distributed.kill((getfield(#self#::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig}, :config)::Distributed.WorkerConfig).process::Union{Nothing, Base.Process}, (profile_sig::Tuple{String, Int64})[2]::Int64)
└────────────────────
```
```
┌ (::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig})() @ Distributed /workpath/Distributed.jl/src/managers.jl:761
│ no matching method found `kill(::Nothing, ::Int64)` (1/2 union split): Distributed.kill((getfield(#self#::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig}, :config)::Distributed.WorkerConfig).process::Union{Nothing, Base.Process}, (Distributed.Base).SIGQUIT::Int64)
└────────────────────
```
```
┌ (::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig})() @ Distributed /workpath/Distributed.jl/src/managers.jl:766
│ no matching method found `kill(::Nothing, ::Int64)` (1/2 union split): Distributed.kill((getfield(#self#::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig}, :config)::Distributed.WorkerConfig).process::Union{Nothing, Base.Process}, (Distributed.Base).SIGKILL::Int64)
└────────────────────
```
```
┌ (::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig})() @ Distributed /workpath/Distributed.jl/src/managers.jl:752
│ no matching method found `process_exited(::Nothing)` (1/2 union split): Distributed.process_exited((getfield(#self#::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig}, :config)::Distributed.WorkerConfig).process::Union{Nothing, Base.Process})
└────────────────────
```
```
┌ (::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig})() @ Distributed /workpath/Distributed.jl/src/managers.jl:764
│ no matching method found `process_exited(::Nothing)` (1/2 union split): Distributed.process_exited((getfield(#self#::Distributed.var"#200#201"{Int64, Int64, Int64, Int64, Distributed.WorkerConfig}, :config)::Distributed.WorkerConfig).process::Union{Nothing, Base.Process})
└────────────────────
```
(cherry picked from commit e19a4bf)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 79.46% 79.47% +0.01%
==========================================
Files 10 10
Lines 1958 1959 +1
==========================================
+ Hits 1556 1557 +1
Misses 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesWrigley
requested changes
Feb 20, 2026
Co-authored-by: James Wrigley <JamesWrigley@users.noreply.github.com>
JamesWrigley
requested changes
Feb 21, 2026
| if profile_sig !== nothing | ||
| @warn("Sending profile $(profile_sig[1]) to worker $(pid)") | ||
| kill(config.process, profile_sig[2]) | ||
| kill(config.process::Process, profile_sig[2]) |
Member
There was a problem hiding this comment.
Sorry, I also meant that we could reuse the process variable in the other places in the function like this one and below.
Member
Author
There was a problem hiding this comment.
Ahh, yes that makes more sense.
Member
Author
There was a problem hiding this comment.
Alright, I pushed fded14b.
Can you take a look and make sure that I found all locations of config.process?
Member
There was a problem hiding this comment.
In those functions, yep looks like you got them all.
…use the `process` variable when needed
DilumAluthge
added a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
…ess_exited(...)` This is similar to JuliaLang/Distributed.jl#172 (JuliaLang/Distributed.jl@231da28)
DilumAluthge
added a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
…ess_exited(...)` This is similar to JuliaLang/Distributed.jl#172 (JuliaLang/Distributed.jl@231da28) (cherry picked from commit b856957)
63 tasks
DilumAluthge
added a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
…ess_exited(...)` This is similar to JuliaLang/Distributed.jl#172 (JuliaLang/Distributed.jl@231da28) (cherry picked from commit b856957)
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e19a4bf)