intervals: pass precision to BigFloat instead of changing globally#614
Closed
nsajko wants to merge 1 commit into
Closed
intervals: pass precision to BigFloat instead of changing globally#614nsajko wants to merge 1 commit into
BigFloat instead of changing globally#614nsajko wants to merge 1 commit into
Conversation
Taking the lock is still necessary after this change. It'd be necessary to audit all `BigFloat` methods to prove otherwise. Also see JuliaLang/julia#49749, which fixes some of them in Julia `Base`.
Member
|
Thx for giving a shot at fixing these issues. I went a different way in PR #615 by completely removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking the lock is still necessary after this change. It'd be necessary to audit all
BigFloatmethods to prove otherwise. Also see JuliaLang/julia#49749, which fixes some of them in JuliaBase.