Fix: MAT_v5.getvarnames(): Read variable header with opaque type support#244
Merged
Merged
Conversation
Contributor
Author
|
CC @matthijscox |
Member
|
Nice! |
Contributor
Author
|
Done! There's also #241 which you can merge first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAT_v5.getvarnames()did not account for the different variable header format for opaque type variables. This resulted in methods likekeys(file),haskey(file, "var")andread(file, "var")erroring out.For opaque type variables, the second header element is the variable name. For all other types, the third header element is the variable name. The fix below reads variable name based on variable type (opaque/non-opaque).
Misc: Additionally, variables with no names are skipped (this is always the subsystem block)
Fixes #242