Skip to content

Bug fix trace test fails for witness sets with real linear subspace - #728

Merged
PBrdng merged 3 commits into
mainfrom
bug-fix--trace_test-fails-for-witness-sets-with-real-linear-subspace
Aug 2, 2026
Merged

Bug fix trace test fails for witness sets with real linear subspace#728
PBrdng merged 3 commits into
mainfrom
bug-fix--trace_test-fails-for-witness-sets-with-real-linear-subspace

Conversation

@PBrdng

@PBrdng PBrdng commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

This fixes #726

@PBrdng

PBrdng commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@oskarhenriksson ?

@oskarhenriksson

Copy link
Copy Markdown
Contributor

Looks like a very elegant fix to me! Maybe there should be a regression test for this, e.g., by adding

@test trace_test(W_L) < 1e-8

after line 23 here:

@testset "affine" begin
@var x y
F = System([x^2 + y^2 - 5], [x, y])
W = witness_set(F)
@test dim(W) == 1
@test codim(W) == 1
@test degree(W) == 2
@test solutions(W) isa Vector{Vector{ComplexF64}}
@test results(W) isa Vector{PathResult}
L = LinearSubspace([1 1], [-1])
W_L = witness_set(W, L)
@test degree(W_L) == 2
@test sort(real.(solutions(W_L))) [[-2, 1], [1, -2]]
@test linear_subspace(W_L) == L
@test trace_test(W) < 1e-8
end

@PBrdng
PBrdng merged commit d7fbc6c into main Aug 2, 2026
6 checks passed
@PBrdng
PBrdng deleted the bug-fix--trace_test-fails-for-witness-sets-with-real-linear-subspace branch August 2, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trace_test fails for witness sets with real linear subspace

2 participants