Skip to content

Remove legacy Grisu #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonDanisch merged 4 commits into from
Dec 11, 2025
Merged

Remove legacy Grisu #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6ad7ae
Remove legacy Grisu
laborg Dec 6, 2025
d489982
Update Project version
laborg Dec 6, 2025
e1763ab
Merge branch 'master' into rmgrisu
SimonDanisch Dec 9, 2025
e510033
revert unrelated code removal
laborg Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
name = "Showoff"
uuid = "992d4aef-0814-514b-bc4d-f2e9a6c4116f"
author = ["Daniel C. Jones (@dcjones)"]
version = "1.0.3"
version = "1.1.0"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Grisu = "42e2da0e-8278-4e71-bc24-59509adca0fe"

[compat]
Grisu = "1"
julia = "1"
julia = "1.10"

[extras]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
11 changes: 1 addition & 10 deletions src/Showoff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,10 @@ module Showoff

using Dates

if isdefined(Base, :Ryu)
include("ryu.jl")
else
include("grisu.jl")
end
include("ryu.jl")

export showoff

# suppress compile errors when there isn't a grisu_ccall macro
macro grisu_ccall(x, mode, ndigits)
quote end
end

# Fallback
function showoff(xs::AbstractArray, style=:none)
result = Vector{String}(undef, length(xs))
Expand Down
142 changes: 0 additions & 142 deletions src/grisu.jl
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ using Printf
const drops0s = !isdefined(Base, :Ryu)

@testset "Internals" begin
@test Showoff.@grisu_ccall(1, 2, 3) === nothing
if isdefined(Showoff, :Grisu)
@test Showoff.grisu(1.0, Showoff.Grisu.SHORTEST, 2) == (1, 1, false, Showoff.Grisu.DIGITS)
end

let x = [1.0, Inf, 2.0, NaN]
@test Showoff.concrete_minimum(x) == 1.0
@test Showoff.concrete_maximum(x) == 2.0
Expand Down