KI Sub-groups#668
Open
christiangnrd wants to merge 17 commits into
Open
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Closed
christiangnrd
force-pushed
the
subgroups
branch
from
6852410 to
84730d2
Compare
christiangnrd
force-pushed
the
subgroups
branch
7 times, most recently
from
daea025 to
6343fd2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 64.04% 64.22% +0.18%
==========================================
Files 23 23
Lines 1969 2010 +41
==========================================
+ Hits 1261 1291 +30
- Misses 708 719 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christiangnrd
force-pushed
the
subgroups
branch
from
6343fd2 to
a86cc8c
Compare
christiangnrd
force-pushed
the
subgroups
branch
from
a86cc8c to
6f4a517
Compare
christiangnrd
force-pushed
the
subgroups
branch
5 times, most recently
from
f0a545c to
8858825
Compare
christiangnrd
force-pushed
the
subgroups
branch
3 times, most recently
from
7ddba7e to
8de2c42
Compare
christiangnrd
force-pushed
the
subgroups
branch
from
8de2c42 to
82d32db
Compare
christiangnrd
force-pushed
the
subgroups
branch
2 times, most recently
from
409a1e7 to
08a8130
Compare
christiangnrd
force-pushed
the
subgroups
branch
3 times, most recently
from
b08bc66 to
2a9d804
Compare
vchuravy
reviewed
Jul 2, 2026
| return config | ||
| end | ||
| @noinline function _compiler_config(dev; kernel = true, name = nothing, always_inline = false, kwargs...) | ||
| @noinline function _compiler_config(dev; kernel = true, name = nothing, always_inline = false, sub_group_size::Union{Nothing, Int} = 32, kwargs...) |
Member
There was a problem hiding this comment.
Did you try different defaults here?
Member
Author
There was a problem hiding this comment.
I didn't. I just went with what is most common on the GPU side
Member
Author
|
@vchuravy I added a |
vchuravy
reviewed
Jul 3, 2026
christiangnrd
force-pushed
the
subgroups
branch
2 times, most recently
from
6d6616a to
5c2d911
Compare
christiangnrd
commented
Jul 4, 2026
Co-Authored-By: Anton Smirnov <tonysmn97@gmail.com>
All backends must support them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.