Skip to content

Put doctests in test suite#153

Merged
nalimilan merged 4 commits into
JuliaData:mainfrom
abhro:doctests
Jun 19, 2026
Merged

Put doctests in test suite#153
nalimilan merged 4 commits into
JuliaData:mainfrom
abhro:doctests

Conversation

@abhro

@abhro abhro commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Run doctests as part of test suite

@abhro

abhro commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

skipmissings throws up deprecation warnings, not sure how to handle that yet. Doctests won't pass until that's been dealt with.

@abhro abhro force-pushed the doctests branch 2 times, most recently from 5377576 to fb958ae Compare June 13, 2026 00:13
@abhro

abhro commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Tried the jldoctest filters, they don't seem to work for some reason. Attempted patch:

diff --git a/src/Missings.jl b/src/Missings.jl
index 35cfd18..a17bd02 100644
--- a/src/Missings.jl
+++ b/src/Missings.jl
@@ -237,7 +237,8 @@ skipping elements at positions where at least one of the iterators returns `miss
 (listwise deletion of missing values).

 # Examples
-```jldoctest
+
+```jldoctest; filter = r".*Warning:.*\\n.*\\n.*"
 julia> x = [1, 2, missing, 4]; y = [1, 2, 3, missing];

 julia> tx, ty = skipmissings(x, y);
@@ -464,7 +465,7 @@ to `skipmissing` and elements for which `f` returns `false`. This method
 only applies when all iterators passed to `skipmissings` are arrays.

 # Examples
-```jldoctest
+```jldoctest; filter = r".*Warning:.*\\n.*\\n.*"
 julia> x = [missing; 2:9]; y = [2:9; missing];

 julia> mx, my = skipmissings(x, y);

@abhro

abhro commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

I'm just gonna turn doctests off for those two particular blocks, maybe that'll help.

@abhro

abhro commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Added compat for Documenter v0.27 so that Pkg resolve doesn't fail on Julia 1.0. Note that the doctests only run on Julia v1.6+, so this isn't even an issue because we'll not be using Documenter, but since we can't add packages conditionally based on Julia version (AFAIK), this stops the CI from erroring out where it installs an unnecessary dependency of Documenter.

@abhro

abhro commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Now the Windows CI test fails because of different word size on x86. 🤦 Pushing commit to fix that 🤞

@abhro abhro marked this pull request as ready for review June 13, 2026 00:28

@nalimilan nalimilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nalimilan nalimilan merged commit b7f3390 into JuliaData:main Jun 19, 2026
6 checks passed
@abhro abhro deleted the doctests branch June 19, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants