Use 'min' Julia version in ci.yml#152
Merged
Merged
Conversation
Make the CI test on lowest supported version as stated in Project.toml. Should also serve as an indicator if the minimum Julia version needs to be bumped
Contributor
Author
|
gentle bump |
Member
|
I think it would be good if you mention someone who knows these configuation files and could competently review it. Thank you! |
Contributor
Author
|
Hmm. I'm not sure who the current maintainers of this package are. I'll dig around. |
Contributor
Author
|
From the blame, it seems @quinnj was most involved in CI setup. Requesting review. |
Member
|
The issue is about competences. E.g. I could review implementation changes, but these are CI changes and I do not know current standards in this domain. |
Contributor
Author
|
Requesting review from @quinnj |
DilumAluthge
left a comment
DilumAluthge
left a comment
Member
There was a problem hiding this comment.
I personally prefer the old branches syntax, could you revert back to that?
Apart from that LGTM.
There's no docs site for this project, and it doesn't look to be planned
DilumAluthge
approved these changes
Jun 12, 2026
DilumAluthge
approved these changes
Jun 12, 2026
Contributor
Author
|
Thank you! |
Member
|
Thank you for seeing this through! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the CI test on lowest supported version as stated in Project.toml. Should also serve as an indicator if the minimum Julia version needs to be bumped