Skip to content

gcmarray internals revamp, skip allocs by default in read and similar - #227

Merged
gaelforget merged 8 commits into
masterfrom
various_20260718_exp2
Aug 5, 2026
Merged

gcmarray internals revamp, skip allocs by default in read and similar#227
gaelforget merged 8 commits into
masterfrom
various_20260718_exp2

Conversation

@gaelforget

@gaelforget gaelforget commented Jul 29, 2026

Copy link
Copy Markdown
Member
  • similar no longer allocates InnerArrays by default (likely a breaking change)
    • read! instead does the alloc when needed
    • full_init=false vastly reduces allocs across the package
    • old behavior is currently recovered via full_init keyword arg
    • not yet implemented for the broadcasted version
  • getindex, view, and similar were first rewritten, which reduced allocs to start with
  • lazy init — copyto! will allocate on first write
  • use full_init=true when needed; add missing tests
  • rename full_init arg as allocate, update docstrings

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.53608% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.30%. Comparing base (124cc5a) to head (55562ae).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/types/gcmarray.jl 82.95% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   87.50%   87.30%   -0.21%     
==========================================
  Files          37       37              
  Lines        3538     3600      +62     
==========================================
+ Hits         3096     3143      +47     
- Misses        442      457      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaelforget gaelforget changed the title gcmarray internals revamp (WIP) gcmarray internals revamp, skip allocs by default in read and similar Aug 5, 2026
@gaelforget
gaelforget merged commit e1ec6a4 into master Aug 5, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant