Add package_linux_mmtk image w/ Rust toolchain#288
Merged
Conversation
DilumAluthge
left a comment
DilumAluthge
left a comment
Member
There was a problem hiding this comment.
This also seems to modify the regular package_linux. Is that just NFC refactoring (are you just moving the code out into gcc.jl), or are you making actual functional changes to package_linux?
Julia's MMTk garbage collector (WITH_THIRD_PARTY_GC=mmtk) builds a Rust binding from source with `cargo` during the Julia build, and its build.rs runs `bindgen` (which needs libclang) to generate the FFI bindings. None of the existing rootfs images carry Rust or libclang. Add a dedicated `package_linux_mmtk` image rather than extending the shared `package_linux` (which every Linux build job downloads), since the Rust std lib and clang add several hundred MB only the MMTk job needs. It is `package_linux` plus `clang`/`libclang-dev` and a pinned Rust toolchain. Rust is installed from the official standalone distribution (not rustup) straight into /usr/local, so `cargo`/`rustc` land on the default PATH and work in the non-login, non-interactive shells Buildkite uses, with no RUSTUP_HOME/CARGO_HOME plumbing and no toolchain download at Julia build time. The pinned version (1.92.0) must be kept in sync with the binding's rust-toolchain file in JuliaLang/julia. Factor the shared GCC 9 cross-toolchain install out of package_linux.jl into install_gcc_toolchain so the two images stay in sync by construction, mirroring the existing install_awscli helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
That's intended to be an NFC refactoring so that it can be used in package_linux_mmtk
|
DilumAluthge
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for JuliaLang/julia#62054.
The Rust version pinning is a bit strict. We may want to relax that in the binding or rely on
rustup, etc. but for now this tries to bake a synchronized version of the toolchain into the image. I don't think we're trying to be on a particularly bleeding edge version of Rust, so the version should be fairly stable.Created entirely by Claude Opus 4.8 noreply@anthropic.com (reviewed by me)