Skip to content

fix: fix stack overflow when converting Term to non-concrete coefficient type - #332

Merged
blegat merged 2 commits into
JuliaAlgebra:masterfrom
AayushSabharwal:as/convert-stack-overflow
Aug 16, 2025
Merged

fix: fix stack overflow when converting Term to non-concrete coefficient type#332
blegat merged 2 commits into
JuliaAlgebra:masterfrom
AayushSabharwal:as/convert-stack-overflow

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Contributor

No description provided.

@AayushSabharwal
AayushSabharwal force-pushed the as/convert-stack-overflow branch from f6f496e to d61356e Compare August 8, 2025 18:00
@blegat

blegat commented Aug 9, 2025

Copy link
Copy Markdown
Member

Yes, the conversion and promotion code is a bit finicky but if you pass all the tests, it should be good to go.

@AayushSabharwal
AayushSabharwal force-pushed the as/convert-stack-overflow branch from a181e5b to f2e3b73 Compare August 14, 2025 11:57
@AayushSabharwal

Copy link
Copy Markdown
Contributor Author

Bump 😅

@blegat blegat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blegat
blegat merged commit 9a343be into JuliaAlgebra:master Aug 16, 2025
8 of 10 checks passed
@AayushSabharwal
AayushSabharwal deleted the as/convert-stack-overflow branch August 17, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants