Skip to content

Implements implicit_basis for SemisimpleBasis #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 1 commit into from
May 2, 2026
Merged

Implements implicit_basis for SemisimpleBasis #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/fixed.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ Base.getindex(b::SimpleBasis, i::Integer) = b.elements[i]
Base.iterate(b::SimpleBasis) = iterate(b.elements)
Base.iterate(b::SimpleBasis, st) = iterate(b.elements, st)

function MA.promote_operation(
::typeof(implicit_basis),
::Type{<:SimpleBasis{T}},
) where {T}
return MA.promote_operation(SA.basis, T)
end

implicit_basis(basis::SimpleBasis) = SA.basis(first(basis.elements))

"""
struct SemisimpleElement{P}
elements::Vector{P}
Expand Down Expand Up @@ -59,6 +68,13 @@ struct SemisimpleBasis{T,B<:SA.ExplicitBasis{T}} <:
bases::Vector{B}
end

function MA.promote_operation(
::typeof(implicit_basis),
::Type{<:SemisimpleBasis{T,B}},
) where {T,B}
return MA.promote_operation(implicit_basis, B)
end

Base.length(b::SemisimpleBasis) = length(first(b.bases))

function _iterate(b::SemisimpleBasis, elem_state)
Expand Down
6 changes: 6 additions & 0 deletions test/fixed.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ end

sb = MB.SimpleBasis([ae1, ae2, ae3])

@test MA.promote_operation(MB.implicit_basis, typeof(sb)) ==
typeof(MB.implicit_basis(sb))

@testset "length" begin
@test length(sb) == 3
end
Expand Down Expand Up @@ -120,6 +123,9 @@ end
sb = MB.SimpleBasis([ae1, ae2, ae3])
semi = MB.SemisimpleBasis([sb])

@test MA.promote_operation(MB.implicit_basis, typeof(semi)) ==
typeof(MB.implicit_basis(semi))

@test length(semi) == 3
@test length(semi.bases) == 1

Expand Down
Loading