Major rework and new features - #9
Conversation
|
Wow, impressive. Thanks. At a first glance it seems thought through and I've already spotted some obvious improvements over the original. I'm not sure how to approach this change. Like you said, the diff isn't very useful and there are lots of different changes all in one commit. It will probably take me some time to review. I'm low on spoons and this is a lot. But although my natural tendency is to reject major works like this straight away, this one does seem worth serious consideration. |
|
@Juerd any updates? It's been quite a long time and I would love to see the new features end up on tootpick.org Can I help you somehow? |
|
@Juerd I really don't want to start a fork over this and get a new domain but also think the new features and improved accessibility are important enough to not sit around endlessly :( I get that you're probably busy but is there really nothing I can do to help you with the review? I mean checking the js that I didn't introduce any malicious code also shouldn't take more than 10 minutes. And if you tested the update in the browser and seen for yourself that the main functionality isn't broken it's really not that necessary to go over the code line by line now if you're short on time. |
Hey @Juerd,
so I recently stumbled upon tootpick because I needed a share to Mastodon link. I thought the domain was pretty cool and the core functionality worked reasonably well but I also thought it lacked quite a few features and LOTS of improvements of the user experience. So I took the time and made a major rework of the project. At this point I kind lost track of everything I changed compared to the current version. I just kept going until I thought everything was just right. I can be really nitpicky.
Here is a rough overview of everything I added/changed:
The website gets all 100 scores on lighthouse across both mobile and desktop. I am not an experienced web developer but I am pretty happy with the result. Because I changed so much the git diff really isn't helpful. I recommend you just open the html file in your local browser and play around with my version. See how it feels and try to break it. I am happy to hear your ideas and feedback. Feel free to ask all the questions you have on whatever design choice I made.
I am on vacation til Sunday but I'll reply ASAP when I am back.