Adding custom and masked password fields in the AP Config page for custom password variables - Solution to issue #33 - #34
Open
Valdez-x wants to merge 2 commits into
Open
Adding custom and masked password fields in the AP Config page for custom password variables - Solution to issue #33#34Valdez-x wants to merge 2 commits into
Valdez-x wants to merge 2 commits into
Conversation
Owner
|
Thanks for the PR. I've left a few comments for improvements. I'm not entirely sure about the name |
Author
|
Sounds good Juerd. Would also be nice if on the first run the box was completely blank instead of starting with the mask already there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #33.
-Adds a new WiFiSettingsClass::passwordstring and WiFiSettingsPasswordString struct that are copies of WiFiSettingsClass::string and WiFiSettingsString struct but has the html value hardcoded to the value
##**##**##**and the html value is not updated when a new value entered.-for loop at line 410 checks the args if the custom password field already has the mask
##**##**##**so that it only stores a new value if the value has been changed from the mask##**##**##**